cli: consume external runtime-mappings#49
Conversation
|
/cc @squeed |
lucab
force-pushed
the
ups/runtime-mappings
branch
2 times, most recently
from
ed5d595 to
f4043f1
Compare
cli/common.go
Outdated
|
|
||
| // parseFlags parses CLI options, returning a populated configuration for the bootstrap agent | ||
| func parseFlags() (internal.Config, error) { | ||
| func parseFlags(runtimeMappingsPath string) (internal.Config, error) { |
There was a problem hiding this comment.
can you call this something like "defaultRuntimeMappingsPath"? Just so it's clear that this is a fallback.
There was a problem hiding this comment.
Ack. I've also left a docstring note to describe argument usage.
internal/versions.go
Outdated
| // Conditionally try ConfigMap from api-server first (bootstrapper only) | ||
| if !localOnly { | ||
| logrus.Debug("Querying api-server for runtime mappings ConfigMap") | ||
| manifest, err := a.versionFromAPIServer() |
There was a problem hiding this comment.
should this be versionManifestFromAPIServer?
There was a problem hiding this comment.
Definitely a good catch! It looks like I fixed this locally but forgot to push :(
|
Seems reasonable. I somehow wish there were a simpler way to plumb this all up, but I can't think of one. |
lucab
force-pushed
the
ups/runtime-mappings
branch
2 times, most recently
from
7608b6f to
fb1e861
Compare
This updates tectonic-torcx to consume runtime-mappings coming from an external source. Mapping file will be bind-mounted at runtime: * boostrapper will receive the one provided by the installer * pre-hook will receive it as a config-map from the cluster
lucab
force-pushed
the
ups/runtime-mappings
branch
from
fb1e861 to
30987e0
Compare
lucab
changed the title
|
@squeed this is ready to go, PTAL. We can tag |
|
You should update the example hook yaml file to include the configmap. |
|
@squeed yep thanks, pushed an additional commit with deployment examples. |
2 participants
This updates tectonic-torcx to consume runtime-mappings coming from an
external source. Mapping file will be bind-mounted at runtime: